Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize 'AS' in Dockerfile examples #2133

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

jakeva
Copy link
Member

@jakeva jakeva commented Mar 24, 2025

[x] Check if this is a typo or other quick fix and ignore the rest :)

Align with Dockerfile conventions, and closes #2127

@jakeva jakeva self-assigned this Mar 24, 2025
@jakeva jakeva requested a review from a team as a code owner March 24, 2025 05:13
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit be92644
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/67e0eb5ae160980008f306e2
😎 Deploy Preview https://deploy-preview-2133--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jakeva jakeva force-pushed the fix-capitalization branch from a311fc3 to ef7a898 Compare March 24, 2025 05:16
@jakeva jakeva force-pushed the fix-capitalization branch from ef7a898 to be92644 Compare March 24, 2025 05:19
Copy link
Contributor

@kallewesterling kallewesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I looked over the codebase to make sure that none had been missed as well, for quality purposes.

@ltagliaferri ltagliaferri merged commit aa9ee79 into chainguard-dev:main Mar 24, 2025
6 of 7 checks passed
@jakeva jakeva deleted the fix-capitalization branch March 24, 2025 22:30
SharpRake pushed a commit to SharpRake/edu that referenced this pull request Mar 31, 2025
[x] Check if this is a typo or other quick fix and ignore the rest :)

Align with [Dockerfile
conventions](https://docs.docker.com/reference/dockerfile/#format), and
closes chainguard-dev#2127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile "as" should be capital "AS"
3 participants