feat(attestation): update contracts on attestation init #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Apr 15, 2025
There was a problem hiding this comment.
I find this code difficult to follow.
The way I see this is
- You provide a contractRef
- no -> done
- yes: It can be two things
- a file or URL
- Load the content of the file or URL
- Check if the workflow exists
- yes? -> update the contract (the associated one) with new content
- no? -> create a default contract with content
- an existing (or not) contract name -> just pass the reference to the att init create.
- a file or URL
|
I've refactored it, please take a look |
javirln
approved these changes
Apr 25, 2025
migmartri
approved these changes
Apr 26, 2025
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
added a commit
to migmartri/chainloop
that referenced
this pull request
May 4, 2025
…nloop-dev#1974)" This reverts commit 5a3ccd9.
migmartri
added a commit
to migmartri/chainloop
that referenced
this pull request
May 4, 2025
…nloop-dev#1974)" This reverts commit 5a3ccd9. Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
added a commit
that referenced
this pull request
May 4, 2025
…" (#2017) Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
--contractargument inatt initwas used only in the case the workflow must be created. With this change, the contract is always updated, no matter if the workflow is new or not.Chainloop takes care of the actual update happening only if there are changes in the contract content.
Fixes #1694