Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support auto completion #139

Merged
merged 8 commits into from
Mar 23, 2022
Merged

support auto completion #139

merged 8 commits into from
Mar 23, 2022

Conversation

Hexilee
Copy link
Member

@Hexilee Hexilee commented Mar 15, 2022

  • support global static completion
  • support dynamic completion for UID of recover subcommand

Hexilee added 3 commits March 15, 2022 17:50
@Hexilee
add subcommand completion
8d98692 
Signed-off-by: xixi <i@hexilee.me>
@Hexilee
add uid completion for recover
a2b363f 
Signed-off-by: xixi <i@hexilee.me>
@Hexilee
fix uid completion for recover
3460ebe 
Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from fewdan and STRRL March 15, 2022 11:14
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2022
View reviewed changes
Hexilee added 3 commits March 15, 2022 19:48
@Hexilee
handle errors
9cb1a59 
Signed-off-by: xixi <i@hexilee.me>
@Hexilee
bump cobra to 1.4.0
e0da300 
Signed-off-by: xixi <i@hexilee.me>
@Hexilee
go mod tidy
2c86856 
Signed-off-by: xixi <i@hexilee.me>
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Mar 17, 2022
WangXiangUSTC
WangXiangUSTC reviewed Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, this feature is so cool!

@Hexilee
resolve comments
8078c77 
Signed-off-by: xixi <i@hexilee.me>
@WangXiangUSTC
Copy link
Collaborator

LGTM

@WangXiangUSTC
Copy link
Collaborator

@Andrewmatilde PTAL

Andrewmatilde
Andrewmatilde approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job！

Andrewmatilde
Andrewmatilde approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job！

@WangXiangUSTC
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

@WangXiangUSTC: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WangXiangUSTC
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8078c77

@ti-chi-bot ti-chi-bot merged commit d93fc1f into chaos-mesh:main Mar 23, 2022
@cwen0 cwen0 mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@Andrewmatilde Andrewmatilde Andrewmatilde approved these changes

@fewdan fewdan Awaiting requested review from fewdan

@STRRL STRRL Awaiting requested review from STRRL

Assignees
No one assigned
Labels
size/XL status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hexilee @ti-chi-bot @WangXiangUSTC @Andrewmatilde