Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vm attack #158

Merged
merged 3 commits into from
May 24, 2022
Merged

support vm attack #158

merged 3 commits into from
May 24, 2022

Conversation

WangXiangUSTC
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC commented May 5, 2022

Signed-off-by: xiang xiang13225080@163.com

close issue #25

usage:

./bin/chaosd attack vm -h
vm attack by using virsh

Usage:
  chaosd attack vm attack [flags]

Flags:
  -h, --help             help for vm
  -v, --vm-name string   The name of the vm to be destoryed

Global Flags:
      --log-level string   the log level of chaosd. The value can be 'debug', 'info', 'warn' and 'error'
      --uid string         the experiment ID

Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 5, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xiang <xiang13225080@163.com>
@Andrewmatilde
Copy link
Member

In my opinion, codes for downloading virsh should be added in Makefile.

@Andrewmatilde
Copy link
Member

Rest LGTM

@WangXiangUSTC
Copy link
Collaborator Author

In my opinion, codes for downloading virsh should be added in Makefile.

Users need to download virsh by yum or apt, depending on the Linux distribution. I think we can add the download command in the document

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I agree with you , LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented May 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c3494cc

@cwen0
Copy link
Member

cwen0 commented May 23, 2022

/merge

@WangXiangUSTC
Copy link
Collaborator Author

/run-all-tests

@WangXiangUSTC
Copy link
Collaborator Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L and removed size/XL labels May 24, 2022
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b49eef0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants