support DNS chaos #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
AsterNighT
reviewed
Apr 21, 2021
| if err != nil { | ||
| return errors.WithStack(err) | ||
| switch attack.Action { | ||
| case core.NetworkDNSAction: |
There was a problem hiding this comment.
That seems a bit weird. Why can't we use some if attack.NeedApplyDNS()?
There was a problem hiding this comment.
DNS is different from delay, loss ..., it doesn't need to apply ipset, tc and iptables, so I think it's better to split them by switch
There was a problem hiding this comment.
But certainly DNSAttack will have attack.NeedApplyIpset() == false, so the original way would work properly?
There was a problem hiding this comment.
Yes, it can work, but I think use switch can make the logic more clear
AsterNighT
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiang xiang13225080@163.com
fix #41, this pr just support update the dns server in /etc/resolv.conf
TODO: map specified host to specified IP
./bin/chaosd attack network dns --help attack DNS server Usage: chaosd attack network dns [flags] Flags: --dns-server string update the DNS server in /etc/resolv.conf with this value (default "123.123.123.123") -h, --help help for dns Global Flags: --log-level string the log level of chaosd, the value can be 'debug', 'info', 'warn' and 'error'