feat: support ssl + client ssl authentication #69
+303
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanshs9
force-pushed
the
ft-auth-certificates
branch
from
a0adf06 to
6b58b4f
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Shivansh Saini <shivanshs9@gmail.com>
shivanshs9
force-pushed
the
ft-auth-certificates
branch
from
6b58b4f to
f444fc1
Compare
|
@shivanshs9 Thanks, could you please add an integration test for it, to make sure the SSL authentication can work |
|
@WangXiangUSTC yep, I'll add one soon. Btw, I already tested it manually. If you'd like to give it a go too, you can generate certificates with this script. And then I did bunch of requests:
|
- ignore output of integration tests Signed-off-by: Shivansh Saini <shivanshs9@gmail.com>
Signed-off-by: Shivansh Saini <shivanshs9@gmail.com>
shivanshs9
force-pushed
the
ft-auth-certificates
branch
from
6aa3131 to
e88298f
Compare
5 tasks
iguoyr
reviewed
Sep 27, 2021
| @@ -32,6 +32,9 @@ func NewServerCommand() *cobra.Command { | |||
|
|
|||
| cmd.Flags().IntVarP(&conf.ListenPort, "port", "p", 31767, "listen port of the Chaosd Server") | |||
| cmd.Flags().StringVarP(&conf.ListenHost, "host", "a", "0.0.0.0", "listen host of the Chaosd Server") | |||
| cmd.Flags().StringVar(&conf.SSLCertFile, "cert", "", "path to a PEM encoded certificate file") | |||
| cmd.Flags().StringVar(&conf.SSLKeyFile, "key", "", "path to a PEM encoded private key file") | |||
| cmd.Flags().StringVar(&conf.SSLClientCAFile, "CA", "", "path to a PEM encoded CA's certificate file") | |||
There was a problem hiding this comment.
It's better to use lowercase ca instead.
There was a problem hiding this comment.
maybe we can update in another pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Authentication and SSL support in Chaosd (as per chaos-mesh/rfcs#14)
For implementation, I referred this guide