Skip to content

Remove enum types #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2020
Merged

Remove enum types #7841

merged 2 commits into from
Oct 3, 2020

Conversation

emmcb
Copy link
Contributor

@emmcb emmcb commented Oct 3, 2020

Resolves #7838

etimberg
etimberg previously approved these changes Oct 3, 2020
View reviewed changes
@xr0master
Copy link
Contributor

We have another enum: enum UpdateModeEnum

@emmcb
Copy link
Contributor Author

emmcb commented Oct 3, 2020

Thanks @xr0master, completely forgot about this one. I changed it to declare enum, this should fix the issue.

@etimberg etimberg added this to the Version 3.0 milestone Oct 3, 2020
@etimberg etimberg added the type: types Typescript type changes label Oct 3, 2020
@etimberg etimberg merged commit d332ebc into chartjs:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

[3.0.0-beta.3] TypeScript issue when building
4 participants
@emmcb @xr0master @etimberg @kurkle