Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Knip to detect and remove unused code #3434

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Add Knip to detect and remove unused code #3434

merged 5 commits into from
Mar 24, 2025

Conversation

targos
Copy link
Member

@targos targos commented Mar 24, 2025

  • chore: add knip and remove unused dependencies
  • chore: remove duplicate exports
  • chore: remove unused exports
  • chore: remove unused files and run knip in CI

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 24, 2025 •
edited
Loading

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 725ef0b
Status: ✅  Deploy successful!
Preview URL: https://416211f1.nmrium.pages.dev
Branch Preview URL: https://knip.nmrium.pages.dev

View logs

@hamed-musallam
Copy link
Member

is there a reason for removing use-what-changed package, sometimes I use it for debugging.

@targos
Copy link
Member Author

targos commented Mar 24, 2025

Oh I didn't know. I can put it back.

@targos targos merged commit 536a427 into main Mar 24, 2025
11 checks passed
@targos targos deleted the knip branch March 24, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@targos @hamed-musallam