Use error code to provide more information about verification failure #187
+139
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,13 +140,13 @@ inline result hash( | |||
|
|
|||
| result hash(const epoch_context_full& context, const hash256& header_hash, uint64_t nonce) noexcept; | |||
|
|
|||
| inline bool verify_final_hash(const hash256& header_hash, const hash256& mix_hash, uint64_t nonce, | |||
| const hash256& boundary) noexcept | |||
| inline std::error_code verify_final_hash(const hash256& header_hash, const hash256& mix_hash, | |||
There was a problem hiding this comment.
Did you mean to use ethash_errc here ?
std::error_code is generally used for OS errors.
I believe overall returning an int from enum is enough instead of using the complexity of std::error_category
Just thinking out loud
There was a problem hiding this comment.
No, I wanted this to standardize error handling in C++. There is a separate commit which adds support for it. This additionally adds you ability to print the error message (see https://github.com/torquem-ch/silkworm/pull/444/files#diff-b2566784e825a40094310b333efb70a061749da92037515ebfec3398052f0461R143).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177