Refactor/#67 - ipo domain 로직 개선 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…페이징 조건값을 전달하도록 기존 로직을 대체
… 통해 가져오던 잠재적 문제를 수정
… 에러에 대한 처리 진행 - IllegalArgumentException 발생가능 - 해당 에러를 IG000(BadRequest) CustomException으로 변환하여 사용자에게 노출
명절 및 최근과 같은 공모가 잘 없는 경우를 대비
중복기능제거: 해당기능은 이미 {ipo_index}/comment 에 존재함
- getter 추가 - 반환할 필요없는 값(haveTitle)에 JsonIgnore 추가
…로 분리 comment관련 기능들을 전부 commentService layer로 분리
…었던 문제 수정 - 신규등록일에는 '신규 등록 되었습니다.' 라는 title 문구만 표시하도록 수정
- ipo/schedule 기능을 해당으로 대체가능함 Closes #78
- 더 이상 targetDate를 sql에서 사용하지 않음 (startDate,endDate로 대체) Closes #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67