Skip to content

[BUG] Ann calculation in tests after collection config + handle none in collection config #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Apr 22, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ANN accuracy calculation is incorrect after collection configuration feature since it still uses the space returned in collection metadata so it will always be L2. Changed to use the space returned in collection config
    • If you specify None for collection_config then it always defaults to hnsw currently but it should default to whatever is set in the yaml config. fixed this
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

sanketkedia commented Apr 22, 2025

@sanketkedia sanketkedia requested a review from jairad26 April 22, 2025 20:04
@sanketkedia sanketkedia marked this pull request as ready for review April 22, 2025 20:04
@sanketkedia sanketkedia mentioned this pull request Apr 22, 2025
1 task
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from f871782 to dd45b86 Compare April 22, 2025 22:36
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch 2 times, most recently from 352d95e to 3e08ad2 Compare April 22, 2025 23:16
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from e69e16f to 2c2aad1 Compare April 23, 2025 18:49
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 3e08ad2 to c84100f Compare April 23, 2025 18:49
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from 2c2aad1 to f7f05ff Compare April 23, 2025 20:31
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from c84100f to b93d0ae Compare April 23, 2025 20:31
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from f7f05ff to 638effd Compare April 24, 2025 18:59
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from c436b2a to 2c996ad Compare April 24, 2025 18:59
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch 2 times, most recently from 2cc86a6 to 12d21e6 Compare April 24, 2025 21:40
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 64cc766 to 514e6f8 Compare April 24, 2025 21:40
@sanketkedia sanketkedia force-pushed the 04-22-_bug_handle_uninitialized_spann_segment_reader branch from 12d21e6 to ae596ac Compare April 24, 2025 23:11
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 514e6f8 to 5ed6e01 Compare April 24, 2025 23:12
@sanketkedia sanketkedia changed the base branch from 04-22-_bug_handle_uninitialized_spann_segment_reader to graphite-base/4350 April 24, 2025 23:14
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 5ed6e01 to 7df1917 Compare April 24, 2025 23:14
@graphite-app graphite-app bot changed the base branch from graphite-base/4350 to main April 24, 2025 23:14
@sanketkedia sanketkedia force-pushed the 04-22-_bug_ann_calculation_in_tests_after_collection_config_handle_none_in_collection_config branch from 7df1917 to f2fb1e9 Compare April 24, 2025 23:14
@sanketkedia sanketkedia merged commit 314e0b4 into main Apr 25, 2025
70 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants