elf: do not remove dots from names #1680
Open
+57
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
elf-reader-names
branch
from
89e0865 to
14bd6e2
Compare
lmb
force-pushed
the
elf-reader-names
branch
from
14bd6e2 to
c7b8bd9
Compare
The ELF reader currently strips dots from object names if the kernel doesn't support them. This is against the goal that the ELF reader should produce the same result no matter which environment it is run in. Change the setup around slightly, so that the ELF reader now always allows dots in names. Instead we strip dots if necessary when making the syscalls. This will break users which: * use object names with dots in them * on kernels which don't support dots * which are pinned into bppfs Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
This reverts commit cfd8515. Now that the ELF reader doesn't rely on feature tests anymore we can undo the change to treat EPERM specially. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elf: do not remove dots from names
Revert "features: tolerate EPERM in haveObjName and objNameAllowsDot"