features: return ErrNotSupportedOnOS on windows #1723
Merged
+15
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8d7c47f. Return a sentinel error instead of removing the API outright. This avoids compilation failures on non-Linux platforms. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Switch the windows cross-build back to darwin. We have a dedicated Windows job now, so bringin the darwin build back is more useful. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Align the build tag with the generated files to avoid compilation failures on darwin. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features: return ErrNotSupportedOnOS on windows
CI: cross build for darwin