Upgrade to LLVM 14, introduce clang-format #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Beckers <timo@isovalent.com>
clang-format re-orders common.h to be included after bpf_helper_defs.h, which is not possible due to the latter depending on __u64. Include common.h at the start of bpf_helpers.h instead. Signed-off-by: Timo Beckers <timo@isovalent.com>
This commit adds the clang-format make target, runs it on the whole repository and rebuilds all testdata and example ELFs. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml
index ac44f95..b9a2fb8 100644
--- a/.semaphore/semaphore.yml
+++ b/.semaphore/semaphore.yml
@@ -52,7 +52,7 @@ blocks:
- ( export GOARCH=arm64; go build ./... && for p in $(go list ./...) ; do go test -c $p || exit ; done )
- make clean
- make container-all
- - git diff --exit-code || { echo "generated files are not up to date" >&2; false; }
+ - git diff --exit-code || { echo "found unformatted source files, or generated files are not up to date, run 'make'" >&2; false; }
- pushd ./examples
- go build -v -o "$(mktemp -d)" ./...
- popd
lmb
reviewed
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades testdata and examples to build against LLVM14. Call clang-format during
make.