Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys: update types #630

Merged
merged 1 commit into from
Apr 23, 2022
Merged

sys: update types #630

merged 1 commit into from
Apr 23, 2022

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Apr 20, 2022

Signed-off-by: Florian Lehner dev@der-flo.net

Update the available types with gentypes on a v5.17 vmlinux.

@florianl florianl requested review from lmb and ti-mo April 20, 2022 20:06
@lmb
Copy link
Collaborator

lmb commented Apr 21, 2022

Did you update this by manually invoking gentypes? The idea is to let go generate do the work and use vmlinux-btf.gz as the source of type data.

The "canonical" way to update types.go is to use make VMLINUX=/path/to/vmlinux vmlinux-btf followed by go generate ./internal/sys/

@florianl
Copy link
Contributor Author

yes - I manully invoked gentypes like: $ ./gentypes /path/to/vmlinux.
but I think I get your point, that internal/btf/testdata/vmlinux-btf.gz is missing here.

@@ -918,8 +924,11 @@ type ProgLoadAttr struct {
LineInfoCnt uint32
AttachBtfId uint32
AttachProgFd uint32
_ [4]byte
CoreReloCnt uint32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting :D

Verified

This commit was signed with the committer’s verified signature.
ti-mo Timo Beckers
Signed-off-by: Florian Lehner <dev@der-flo.net>
@lmb lmb merged commit 358b2b4 into master Apr 23, 2022
@lmb lmb deleted the flo-types branch April 23, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants