ringbuf: reduce allocations and syscalls #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
reviewed
May 10, 2022
| if err == errBusy || err == errDiscard { | ||
| continue | ||
| } | ||
| if err == errEOR { |
There was a problem hiding this comment.
Is this a left over from previous experiments? readRecord() does not return errEOR afaict.
Other than that, the changes work fine here.
There was a problem hiding this comment.
Thanks for catching that! Modified one of the tests to exercise this behavior.
florianl
reviewed
May 10, 2022
There is no need to wrap internal sentinel errors, since they are never returned to the user. Not wrapping saves us some allocations.
We don't have to call back into epoll_wait until we've read the full contents of the ring buffer. This reduces the number of syscalls made during busy periods.
|
@lmb thanks! I was just about to submit my github approval. It looks nice to me. AFAICS with this users can also start controlling samples submission better with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringbuf: reduce allocations on the discard and busy paths
ringbuf: reduce the number of epoll_wait calls