We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOTE: This is a similar issue to #389.
At: https://github.com/civictheme/uikit/blob/main/components/01-atoms/link/link.twig#L77
an aria label of aria-label="Opens in a new tab" is set, which a screen reader would read out instead of the content within the link.
aria-label="Opens in a new tab"
If removing this, the screen reader will still alert the user that the link opens in a new window, as..
<span class="ct-visually-hidden">(Opens in a new tab/window)</span>
...is included in the link if is_new_window is enabled. This is because text-icon.twig will include it.
is_new_window
text-icon.twig
Go to https://uikit.civictheme.io/?path=/story/atoms-link--link and check "Opens in a new window".
Screen reader will read out "Opens in a new tab" rather than "This should read out"
Screen reader should read out " This should read out. Opens in a new tab"
The text was updated successfully, but these errors were encountered:
[#436] Removed aria-label from link with 'is_new_window'.
8888c49
Related Drupal issue: https://www.drupal.org/project/civictheme/issues/3488286
Sorry, something went wrong.
[#436] Removed aria-label from link with 'is_new_window'. (#437)
5de5989
fionamorrison23
No branches or pull requests
Summary
NOTE: This is a similar issue to #389.
At: https://github.com/civictheme/uikit/blob/main/components/01-atoms/link/link.twig#L77
an aria label of
aria-label="Opens in a new tab"
is set, which a screen reader would read out instead of the content within the link.If removing this, the screen reader will still alert the user that the link opens in a new window, as..
...is included in the link if
is_new_window
is enabled. This is becausetext-icon.twig
will include it.Steps to reproduce
Go to https://uikit.civictheme.io/?path=/story/atoms-link--link and check "Opens in a new window".
Observed outcome
Screen reader will read out "Opens in a new tab" rather than "This should read out"
Expected outcome
Screen reader should read out " This should read out. Opens in a new tab"

The text was updated successfully, but these errors were encountered: