Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-label from links that open in a new window. #436

Open
alan-cole opened this issue Nov 30, 2024 · 1 comment
Open

Remove aria-label from links that open in a new window. #436

alan-cole opened this issue Nov 30, 2024 · 1 comment
Assignees
Labels
Type: Defect Issue is a defect

Comments

@alan-cole
Copy link
Collaborator

alan-cole commented Nov 30, 2024

Summary

NOTE: This is a similar issue to #389.

At: https://github.com/civictheme/uikit/blob/main/components/01-atoms/link/link.twig#L77

an aria label of aria-label="Opens in a new tab" is set, which a screen reader would read out instead of the content within the link.

If removing this, the screen reader will still alert the user that the link opens in a new window, as..

<span class="ct-visually-hidden">(Opens in a new tab/window)</span>

...is included in the link if is_new_window is enabled. This is because text-icon.twig will include it.

Steps to reproduce

Screenshot 2024-12-01 at 11 00 10 am

Go to https://uikit.civictheme.io/?path=/story/atoms-link--link and check "Opens in a new window".

Observed outcome

Screen reader will read out "Opens in a new tab" rather than "This should read out"

Screenshot 2024-12-01 at 11 03 04 am

Expected outcome

Screen reader should read out " This should read out. Opens in a new tab"
Screenshot 2024-12-01 at 11 03 18 am

@joshua-salsadigital
Copy link
Collaborator

Related Drupal issue: https://www.drupal.org/project/civictheme/issues/3488286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Issue is a defect
Projects
Status: Todo
Development

No branches or pull requests

3 participants