-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-line header #467
Comments
Solution Direction:
Additional changes needed for drupal theme, will be implemented as part of: https://www.drupal.org/project/civictheme/issues/3510841 |
febdao
added a commit
that referenced
this issue
Mar 6, 2025
febdao
added a commit
that referenced
this issue
Mar 9, 2025
febdao
added a commit
that referenced
this issue
Mar 21, 2025
febdao
added a commit
that referenced
this issue
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User story
As an site owner
I want the option to set my site up with a multi-line header
So that I can adhere to branding requirements for the logo
And have a CTA in a prominent position
And allow enough room for more primary menu links
Description
CivicTheme users have reported that the space we have for the primary menu is often not wide enough, especially when they have a co-branded (two) logo, and/or when menu link titles are long.
This new multi-line header design allows the user to have:
When setting up the site, site builder will need an option to choose the current single line header or the new multi-line header.
Design
https://www.figma.com/design/7vl6Aobg7G8gBCcRriNegr/CivicTheme%3A-Design-System-v1.10-(WIP)?node-id=2976-41810&p=f&t=PI2p0JrF8kp9oQcM-0
Acceptance criteria
AC 1 - Display logo in the first row
Given I’m a Content Author
And the multi-line header is enabled
When I add the logo/s
Then they display in the first row should
AC 2 - Display CTA buttons in the first row
Given I’m a Content Author
And the multi-line header is enabled
When I choose to add up to two optional CTA buttons
Then they display on the right side of first row
And I can choose to style them as Primary or Secondary buttons
AC 3 - Display primary menu in the second row
Given I’m a Content Author
And the multi-line header is enabled
When I add primary menu links
Then the primary navigation displays in the second row below the logo / CTA row
AC 4 - Responsive behaviour for multi-line header
Given the multi-line header layout is enabled
When I view the site on different screen sizes
Then the header should be responsive and maintain usability
Accessibility
AC 5 - Header adapts to screen readers
Given I’m an anonymous user using screen reader technology
When the header is announced
Then it conveys its purpose and structure clearly without redundant or missing information
Ac 6 - Header is responsive without loss of accessibility
Given the multi-line header layout is enabled
When the screen size changes
Then all elements should remain accessible and operable, including mobile menu toggles and focus states
AC 7 - Header structure follows semantic HTML
Given I’m an anonymous user
And the multi-line header layout is enabled
When the page is rendered
Then the header uses semantic HTML elements
AC 8 - CTA buttons have accessible labels
Given I’m an anonymous user using screen reader technology
And the multi-line header layout is enabled
When I engage with the CTA buttons
Then each button has meaningful text or an
aria-label
for screen reader usersAC 9 - Menu has proper ARIA roles and attributes
Given I’m an anonymous user using screen reader technology
And the multi-line header layout is enabled
When the menu is rendered
Then it has appropriate ARIA roles such as
role="navigation"
andaria-expanded
for dropdownsAC 10 - CTA buttons are keyboard accessible
Given I’m an anonymous user
And the multi-line header layout is enabled
When I navigate using the keyboard
Then all CTA buttons are focusable and operable via keyboard input
AC 11 - Primary menu is fully navigable via keyboard
Given I’m an anonymous user
And the multi-line header layout is enabled
When I navigate through the menu using the keyboard
Then all menu items are focusable and selectable via keyboard input
AC 12 - Error Handling and Feedback
Given I’m an anonymous user with accessibility needs
When an error occurs (e.g., failed load of a header element)
Then the header should gracefully handle the error without breaking accessibility features, and provide meaningful feedback.
AC 13 - Color Contrast Compliance
Given I’m an anonymous user
When I view the header
Then all text and interactive elements should meet WCAG 2.1 AA contrast ratios.
AC 14 - Focus Order
Given I’m an anonymous user navigating by keyboard
When I move through the header
Then the focus should follow a logical order without skipping interactive elements.
###Solution direction
The text was updated successfully, but these errors were encountered: