Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider resize is incorrect if the fonts are slow to load #468

Open
richardgaunt opened this issue Feb 10, 2025 · 1 comment
Open

Slider resize is incorrect if the fonts are slow to load #468

richardgaunt opened this issue Feb 10, 2025 · 1 comment
Assignees
Labels
State: QA The issue is in QA Type: Defect Issue is a defect
Milestone

Comments

@richardgaunt
Copy link
Collaborator

Summary

Slider calculates the height based on the highest slide in a set. But if a page loads, the slider resizes and then the fonts load the slide height calculation can be incorrect.

Add a listener to fonts load and adjust slider height when this fires.

Steps to reproduce

  1. Slow the loading of fonts
  2. Create a slider
  3. Note the height issue

Observed outcome

Slider height is calculated incorrectly

Expected outcome

Slider height is calculated correctly

@richardgaunt richardgaunt added the Type: Defect Issue is a defect label Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Feb 11, 2025
@fionamorrison23 fionamorrison23 added the State: QA The issue is in QA label Feb 11, 2025
@fionamorrison23 fionamorrison23 moved this from Todo to In Progress in UI Kit Feb 11, 2025
@fionamorrison23 fionamorrison23 added this to the 1.10 milestone Feb 11, 2025
@daniel-grynenko
Copy link

Test Env: DEV
Test Status: PASS
Test Result: Verified that the slider correctly calculates and maintains its height even when fonts load slowly. Simulated a slow font load by blocking the font request in the Network tab and observed whether the slider resized unexpectedly. Confirmed that the sliders height remains stable upon page load and after unblocking the font.

Normal slider height:
Image

Slider height with slow load speed and blocked font request:
Image

@daniel-grynenko daniel-grynenko moved this from In Progress to Done in UI Kit Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: QA The issue is in QA Type: Defect Issue is a defect
Projects
Status: Done
Development

No branches or pull requests

3 participants