Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#356] Updated aria-live for error message to assertive. #455

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Jan 17, 2025

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Updated aria-live for error message to assertive.

Screenshots

Screenshot 2025-01-17 at 3 15 14 pm

@febdao febdao added PR: Needs review Pull request needs a review from assigned developers A11y Issue is related to accessibility labels Jan 17, 2025
@febdao febdao requested a review from richardgaunt January 17, 2025 04:23
@febdao febdao self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.17%. Comparing base (caf1cb1) to head (57face1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files          27       27           
  Lines        1312     1312           
  Branches      312      312           
=======================================
  Hits          304      304           
  Misses        812      812           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 19, 2025 22:30 Inactive
@richardgaunt richardgaunt merged commit 9c0b114 into main Jan 19, 2025
8 checks passed
@richardgaunt richardgaunt deleted the feature/356-error-message-aria-live branch January 19, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Issue is related to accessibility PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants