Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set worker polling interval #197

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

ilouzl
Copy link
Contributor

@ilouzl ilouzl commented Mar 31, 2024

A useful option to override the default 5 sec polling interval of the agent

@jkhenning
Copy link
Member

Hi @ilouzl, looks good - can we add a minimum of 5 seconds? (less than that will just harass the server, I think)

@ilouzl
Copy link
Contributor Author

ilouzl commented Apr 3, 2024

Hi @jkhenning.
Sure!
Done

@jkhenning jkhenning merged commit 98cc0d8 into clearml:master Apr 3, 2024
@ilouzl
Copy link
Contributor Author

ilouzl commented Apr 14, 2024

Hi @jkhenning I'm afraid the PR was buggy.
The deletion of _polling_interval = 5.0 will break services mode.
This is because Worker class now doesn't have a polling_interval member which will cause an error if invoked with commands other than daemon (such as clearml-agent execute in sevices mode).
Do you want me to start another PR for this?

@jkhenning
Copy link
Member

Hi @ilouzl, yes, I see what you mean. I'll push a fix, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants