Replace cl-case calls with cond
#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users are reporting issues with `cl-case`, depending on the Emacs version and build.
plexus
force-pushed
the
cl-case-to-cond
branch
from
7acd7a3 to
6f9ab8f
Compare
|
Did we not have CI on these repos previously? Running tests locally for now but if we continue to poke at these things we should probably set that up again. |
|
Won't pcase be a better fit for some of those use cases? |
|
So Anyway yes |
|
Fine by me. We can always change this down the road. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are reporting issues with
cl-case, depending on the Emacs version andbuild.
See clojure-emacs/cider#2967