Show feature gated bindings in documentaion #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghuaw
force-pushed
the
docsrs-all-features
branch
from
cb78aa3 to
2eed196
Compare
|
@slinkydeveloper Could you please give a quick look at this? This PR contains zero change to the rust code. It's just some quality of life improvement on docs.rs |
Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Signed-off-by: minghuaw <michael.wu1107@gmail.com>
minghuaw
force-pushed
the
docsrs-all-features
branch
from
a8393cc to
e978051
Compare
|
Thanks @minghuaw Sorry for the delay -- I'm on vacation til Sept -- I'll check the AMQP PR then if nobody else has. |
minghuaw
added a commit
to minghuaw/sdk-rust
that referenced
this pull request
Aug 26, 2022
* show feature gated bindings in docsrs * moved crate root docsrs feature * fixed cargo fmt check * removed files that should go with another PR Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply asks docs.rs to build the crate with all features enabled and label the specific feature needed for a particular binding. This can be tested locally with the following command
cargo +nightly doc --no-deps --all-features --open -Z unstable-options --config 'build.rustdocflags=[\"--cfg\", \"docsrs\"]'