-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COM.PRES.Indent #119
Comments
Localization added via #49 |
brigittehuynh
added a commit
that referenced
this issue
Jul 22, 2018
remains valid), tests updated accordingly. Updated extra test file that had CR+LF Windows style end of lines and could not be analyzed by i-Code.
brigittehuynh
added a commit
that referenced
this issue
Aug 20, 2018
- Awk command handling - Quotes and double quotes handling - Cases statements handling - Analysis failure on braces (issue due to [[) The following issues no longer occur although there was no specific correction for them. The overall modifications of the rule must have resolved them: - Comments handling - Forbidden increasing of identation not handled
Merged
Merged
begarco
pushed a commit
to begarco/i-CodeCNES
that referenced
this issue
Jan 25, 2020
…tion (issue cnescatlab#137 remains valid), tests updated accordingly. Updated extra test file that had CR+LF Windows style end of lines and could not be analyzed by i-Code.
begarco
pushed a commit
to begarco/i-CodeCNES
that referenced
this issue
Jan 25, 2020
- Awk command handling - Quotes and double quotes handling - Cases statements handling - Analysis failure on braces (issue due to [[) The following issues no longer occur although there was no specific correction for them. The overall modifications of the rule must have resolved them: - Comments handling - Forbidden increasing of identation not handled
begarco
pushed a commit
that referenced
this issue
Feb 2, 2020
remains valid), tests updated accordingly. Updated extra test file that had CR+LF Windows style end of lines and could not be analyzed by i-Code.
begarco
pushed a commit
that referenced
this issue
Feb 2, 2020
- Awk command handling - Quotes and double quotes handling - Cases statements handling - Analysis failure on braces (issue due to [[) The following issues no longer occur although there was no specific correction for them. The overall modifications of the rule must have resolved them: - Comments handling - Forbidden increasing of identation not handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implementation of the rule COM.PRES.Indent.
Description
Known problems
Awk command handling
Description : The checker raises violation when using awk
Quotes and double quotes handling
Description : Behaviour of the checker becomes inaccurate when reading quotes or double quotes.
Cases statements handling
Description : Case statements is not handled correctly, which leads it to raise false positives.
Comments handling
Description : The checker raises false positives after commented lines. This problem might be due by
ELSE
,CONT
,currentPos
anddesiredPos
in the lex.Analysis failure on braces
Description : It seems that the number of
{}
braces accounting cause crashes of the anaylsis. Might come from the item+([0-9])
of the case. For instance the code beetween braces in :[[ $? != 0 ]] && { echo >&2 the required \"message\" command is not in your PATH; exit 1; }
Forbidden increasing of identation not handled
Description : Bad increasing of indentation is not handled by the checker. For example :
Function declaration
Description : The checker is not handling some types of functions declaration. The problem is the same one as defined for several rules in #49 .
State of the implementation
The text was updated successfully, but these errors were encountered: