Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction erreur COM.xxx #131

Closed
Tom3592 opened this issue Jul 13, 2018 · 1 comment · Fixed by #207
Closed

Correction erreur COM.xxx #131

Tom3592 opened this issue Jul 13, 2018 · 1 comment · Fixed by #207
Assignees
Labels
bug done Used when an issue is implemented but not yet released shell
Milestone

Comments

@Tom3592
Copy link

Tom3592 commented Jul 13, 2018

Expected behavior

We want to correct errors COM.DESIGN.ActiveWait and COM.FLOW.FileExistence in our script

Actual behavior

We did not succeed to correct theses errors

Steps to reproduce behavior

Correction erreur COM.xxx.PPTX

Detection version

i-code 3.0

@WaldoFR
Copy link

WaldoFR commented Jul 13, 2018

Hi,

Thank you for your report.

Solution

ACTWAIT     = "while"{SPACE}*\[{SPACE}*"1"{SPACE}*\]{SPACE}*    |
"read"
[...]
/************************/
/* YYINITIAL STATE      */
/************************/
<YYINITIAL>
        {
                {COMMENT_WORD}  {yybegin(COMMENT);}
                {FUNC}          {location = yytext(); yybegin(NAMING);}
                {ACTWAIT}       {setError(location,"There is an active wait in this point.", yyline+1); }
                {STRING}        {}
                {VAR}           {} /* Clause to match with words */
                [^]             {}
        }

To

NOT_ACTWAIT = "read" {SPACE}* "line"
ACTWAIT     = "while"{SPACE}*\[{SPACE}*"1"{SPACE}*\]{SPACE}*    |
"read"
[...]
/************************/
/* YYINITIAL STATE      */
/************************/
<YYINITIAL>
        {
                {COMMENT_WORD}  {yybegin(COMMENT);}
                {FUNC}          {location = yytext(); yybegin(NAMING);}
                {NOT_ACTWAIT} {}
                {ACTWAIT}       {setError(location,"There is an active wait in this point.", yyline+1); }
                {STRING}        {}
                {VAR}           {} /* Clause to match with words */
                [^]             {}
        }

  • In COM.FLOW.FileExistence, deeper analysis should be done to identify why the redirection is considering "done" as a file instead of a command.

Regards,
Omar Waldmann

Sorry, something went wrong.

@WaldoFR WaldoFR added bug and removed to analyse labels Jul 13, 2018
@begarco begarco added this to the Version 4.1.0 milestone Mar 6, 2020
begarco added a commit that referenced this issue Apr 6, 2020

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
begarco added a commit that referenced this issue Apr 6, 2020

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@begarco begarco added the done Used when an issue is implemented but not yet released label Apr 6, 2020
begarco added a commit that referenced this issue Apr 6, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Feature fix #131 and fix #147
@begarco begarco mentioned this issue Apr 6, 2020
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug done Used when an issue is implemented but not yet released shell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants