Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize font sizes #175

Merged
merged 10 commits into from
Apr 8, 2024
Merged

harmonize font sizes #175

merged 10 commits into from
Apr 8, 2024

Conversation

ute
Copy link
Contributor

@ute ute commented Mar 28, 2024

Choose monaco editor font size according to surrounding div (editorDiv)

Choose monaco editor font size according to surrounding div (editorDiv)
@coatless
Copy link
Owner

@ute I'm going to make this PR the "font-size" change one and, I'll switch #173 to focusing solely on global options. Is that okay?

@ute
Copy link
Contributor Author

ute commented Mar 28, 2024

👍
Please go ahesd, I was initially shy to open two issues / PRs 😊

@coatless
Copy link
Owner

@ute no worries. We appreciate the PRs 😄 👍 💯

@coatless coatless mentioned this pull request Mar 29, 2024
@coatless coatless added this to the 4.2 milestone Mar 29, 2024
@coatless coatless added t: enhancement New feature or request p: low Address issue when time permits labels Mar 29, 2024
@coatless
Copy link
Owner

coatless commented Apr 3, 2024

@ute I think the output size should largely be sync'd now with the code editor text size.

Demo of the `editor-font-size` option in action with smaller and larger text

I added the above demo under docs/demos/qwebr-editor-options.qmd.

Though, given that bootstrap is defining a custom style on the pre tag, we won't be 100% in sync with a raw code cell.

Example of the pre code style

Let me know what you think. If this is okay, we can close it out and move on to the next issue.

@coatless
Copy link
Owner

coatless commented Apr 8, 2024

Going to fold this into main to add a few more options into the editor options demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Address issue when time permits t: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants