Add webhook sinks to the compression option for changefeeds #19582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed: |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
rharding6373
reviewed
May 5, 2025
| @@ -111,7 +111,7 @@ Parameter | <div style="width:100px">Sink Type</div> | <div style= | |||
| Option | Value | Description | |||
| -------|-------|------------ | |||
| <a name="avro-schema-prefix"></a>`avro_schema_prefix` | Schema prefix name | Provide a namespace for the schema of a table in addition to the default, the table name. This allows multiple databases or clusters to share the same schema registry when the same table name is present in multiple databases.<br><br>Example: `CREATE CHANGEFEED FOR foo WITH format=avro, confluent_schema_registry='registry_url', avro_schema_prefix='super'` will register subjects as `superfoo-key` and `superfoo-value` with the namespace `super`. | |||
| <a name="compression"></a>`compression` | `gzip`, `zstd` | Compress changefeed data files written to a [cloud storage sink]({% link {{ page.version.version }}/changefeed-sinks.md %}#cloud-storage-sink). For compression options when using a Kafka sink, see [Kafka sink configuration]({% link {{ page.version.version }}/changefeed-sinks.md %}#kafka-sink-configuration). | |||
| <a name="compression"></a>`compression` | `gzip`, `zstd` | Compress changefeed data files written to:<ul><li>[Cloud storage sinks]({% link {{ page.version.version }}/changefeed-sinks.md %}#webhook-sink)</li><li><span class="version-tag">New in v25.2:</span>[Webhook sinks]({% link {{ page.version.version }}/changefeed-sinks.md %}#cloud-storage-sink)</li></ul>. For compression options when using a Kafka sink, see [Kafka sink configuration]({% link {{ page.version.version }}/changefeed-sinks.md %}#kafka-sink-configuration). | |||
There was a problem hiding this comment.
The links are reversed (webhook sink link is on cloud storage sink text and vice versa)
There was a problem hiding this comment.
Oh whoops! Thanks for catching that :)
asg0451
approved these changes
May 7, 2025
katmayb
force-pushed
the
webhook-compression-option
branch
from
b9fe098 to
5ab74db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-11858
Small addition to the
compressionoption to add webhook sink support.