Avoid printing "Some()" in Server messages

[lolgab]

No description provided.

[lefou]

USing .orNull when we assume it can't be a null (because we checked above) is a bit misleading. We could use .get and make our assumption explicit. (Which could lead to failure after the next refactoring, though)

The .orNull is probably "safer", but I'd add a comment.

[lolgab]

I think we check if they are the same as before, not if they are not null, so we may print null there. I wouldn't comment only because it's a debug print.

[lefou]

If the option might be null, lets use .getOrElse("_"). We replace the unset-value with a _. Or use none if you prefer a word.

I wouldn't comment only because it's a debug print.

IMHO, that doesn't matter. The code must be read and understood nevertheless.

[lolgab]

If the option might be null, lets use .getOrElse("_"). We replace the unset-value with a _. Or use none if you prefer a word.

Consider we are already printing null for the other argument:

Java version changed (Some(/opt/homebrew/opt/openjdk@17) -> null), re-starting server

[lefou]

IMHO, I would fallback to the real used ones on the rhs, e.g. BuildInfo.millVersion and system.