POC: Refactor internal BSP task out of JavaModule #5214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lefou
commented
May 28, 2025
lefou
commented
- POC: Deprecate private[mill] bsp-Task
- Mark overridden API tasks
- POC: Add an implicitly addable module holding BSP tasks and state
This for now only holds a single task, but the idea is to move all bsp-tasks here.
|
Feel free to delete and move things around the API; until 1.0.0 final lands, there aren't any compatibility concerns, so best to squeeze in as much cleanup as we can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.