Skip to content

Add -restore to msbuild invocations for WiX v4 compatibility #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Add -restore to msbuild invocations for WiX v4 compatibility #487

merged 3 commits into from
Mar 23, 2023

Conversation

tristanlabelle
Copy link
Collaborator

Prepares the CI definitions for the migration of the Windows installer to WiX v4, which relies on Nuget and so require a package restore step: swiftlang/swift-installer-scripts#184

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be worried about compatibility with this change? That is, this should be a no-op before the changes for WiX 4 get merged right?

@tristanlabelle
Copy link
Collaborator Author

@compnerd Yes, this is a no-op with our current WiX v3 projects. I tested it locally.

@compnerd compnerd merged commit 0124675 into compnerd:main Mar 23, 2023
@tristanlabelle tristanlabelle deleted the run-msbuild-with-restore branch March 23, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants