Add support for android SDK builds for the toolchain GHA workfow #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

compnerd merged 5 commits into compnerd:main from hyp:eng/android-ci

Jun 26, 2024

Collaborator

hyp commented May 23, 2024

No description provided.

hyp requested review from compnerd, tristanlabelle and hjyamauchi

May 23, 2024 18:19

hyp force-pushed the eng/android-ci branch from 016c506 to 013caeb Compare

May 23, 2024 18:21

compnerd reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

Collaborator

hjyamauchi commented May 23, 2024

It might be worth checking that this won't break the arm64 cross-compile build (build.cmd -HostArchName=ARM64 on X64) or the Apple CI https://ci-external.swift.org/job/swift-main-windows-toolchain-arm64/ (though it's broken at the moment?)

hjyamauchi approved these changes

View reviewed changes

Collaborator

hjyamauchi left a comment

LGTM

tristanlabelle reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

tristanlabelle reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

tristanlabelle reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

tristanlabelle reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Show resolved Hide resolved

tristanlabelle reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

tristanlabelle approved these changes

View reviewed changes

Collaborator

tristanlabelle left a comment

Thanks for iterating to get to this point, seems like it must have been challenging!

hyp mentioned this pull request

Setup Swift SDK builds for Android thebrowsercompany/swift-build#111

Closed

13 tasks

compnerd and others added 3 commits

June 25, 2024 12:27


          GHA: begin wiring up the android builds

ab836f0


          [android] android build support

8fd1ec1


          review fixes

199b79e

hyp force-pushed the eng/android-ci branch from 087ab2a to 199b79e Compare

June 25, 2024 19:28

compnerd reviewed

View reviewed changes

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved


          Another round of fixes

c02d359

compnerd reviewed

View reviewed changes

Owner

compnerd left a comment

This feels very very close!

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved

.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved


          another round of fixes

ee70900

compnerd approved these changes

View reviewed changes

compnerd merged commit 087a9dc into compnerd:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet