Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xscen recipe #23701

Merged
merged 3 commits into from
Aug 21, 2023
Merged

add xscen recipe #23701

merged 3 commits into from
Aug 21, 2023

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Aug 17, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (xscen) and found some lint.

Here's what I've got...

For xscen:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@Zeitsperre
Copy link
Contributor Author

@aulemahal @juliettelavoie @RondeauG

Can you all confirm that you wish to be maintainers? Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xscen) and found it was in an excellent condition.

@Zeitsperre
Copy link
Contributor Author

Zeitsperre commented Aug 17, 2023

@aulemahal Am I correct in assuming that xesmf does not support Windows?

@aulemahal
Copy link

You are correct.

@Zeitsperre
Copy link
Contributor Author

@conda-forge/help-python

Should I be skipping windows explicitly, or should I leave this as noarch: python?

This PR is otherwise ready!

@aulemahal
Copy link

We could remove xESMF as a hard dependency and make the whole "regrid" submodule optional. I would do that only on windows though, not sure if that's a good conda-forge practice.

@Zeitsperre
Copy link
Contributor Author

You can set optional dependencies depending on the platform. This is very much allowed in conda-forge. The question is whether we would want to add this to the xscen package. It's entirely doable, and it would enable Windows users to use (most) of the functionality.

We could open an issue about this in xscen.

@aulemahal
Copy link

I just found out that windows build are made for ESMF since February. Sorry for the false alarm, xscen seems to be usable on all three OSs!

@aulemahal
Copy link

The CI failure seems to be due to esmf-org/esmf#117.

It is interesting that this doesn't happen on the cool OSs.

But anyway, this bug is fixed on ESMF 8.5 which is on the way for a conda-forge release.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 18, 2023

I just found out that windows build are made for ESMF since February. Sorry for the false alarm, xscen seems to be usable on all three OSs!

conda-forge doesn't build ESMF on Windows yet. We couldn't make it work. You can still publish this as noarch and leave the Windows to "error out" at install time, or make ESMF optional internally with some lazy import and make xscen partially funcional on Windows. It all depends on how important ESMF is for this package.

@aulemahal
Copy link

Hum, on our part making (x)ESMF optional is quite easy, but I think we have one dependency (clisops) that also required xESMF.

But, I was able to install ESMF on a windows machine using mamba a few minutes ago. And a win-64 build is listed here : https://anaconda.org/conda-forge/esmf. Were those uploaded manually rather then through the automated conda-forge process ?

The Windows build fails because of a missing environment variable, but the package was indeed installed before that error.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 18, 2023

But, I was able to install ESMF on a windows machine using mamba a few minutes ago. And a win-64 build is listed here : https://anaconda.org/conda-forge/esmf. Were those uploaded manually rather then through the automated conda-forge process ?

Nope. My memory failed me. It was added a while back in conda-forge/esmf-feedstock#65

In theory you are good to go here.

@Zeitsperre
Copy link
Contributor Author

@ocefpaf

I think we can adjust the remaining changes needed within xscen. Our target OS is primarily *nix, so if we can get Windows working within the next release of xscen, that's a bonus. All maintainers have indicated their intent to manage this library. Please feel free to merge!

Thanks!

@ocefpaf
Copy link
Member

ocefpaf commented Aug 21, 2023

The missing env var, ESMFMKFILE should probablt be set in the ESMF feedstock. Can you open an issue there so we can track that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants