-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add xscen recipe #23701
add xscen recipe #23701
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For xscen:
|
@aulemahal @juliettelavoie @RondeauG Can you all confirm that you wish to be maintainers? Thanks! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@aulemahal Am I correct in assuming that xesmf does not support Windows? |
You are correct. |
@conda-forge/help-python Should I be skipping windows explicitly, or should I leave this as This PR is otherwise ready! |
We could remove |
You can set optional dependencies depending on the platform. This is very much allowed in conda-forge. The question is whether we would want to add this to the We could open an issue about this in xscen. |
I just found out that windows build are made for ESMF since February. Sorry for the false alarm, xscen seems to be usable on all three OSs! |
The CI failure seems to be due to esmf-org/esmf#117. It is interesting that this doesn't happen on the cool OSs. But anyway, this bug is fixed on ESMF 8.5 which is on the way for a conda-forge release. |
conda-forge doesn't build ESMF on Windows yet. We couldn't make it work. You can still publish this as noarch and leave the Windows to "error out" at install time, or make ESMF optional internally with some lazy import and make |
Hum, on our part making (x)ESMF optional is quite easy, but I think we have one dependency (clisops) that also required xESMF. But, I was able to install ESMF on a windows machine using mamba a few minutes ago. And a win-64 build is listed here : https://anaconda.org/conda-forge/esmf. Were those uploaded manually rather then through the automated conda-forge process ? The Windows build fails because of a missing environment variable, but the package was indeed installed before that error. |
Nope. My memory failed me. It was added a while back in conda-forge/esmf-feedstock#65 In theory you are good to go here. |
I think we can adjust the remaining changes needed within xscen. Our target OS is primarily *nix, so if we can get Windows working within the next release of xscen, that's a bonus. All maintainers have indicated their intent to manage this library. Please feel free to merge! Thanks! |
The missing env var, |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).