-
Notifications
You must be signed in to change notification settings - Fork 916
Support for schema id in header #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for including the schema ID (or GUID) in the message header as well as updates multiple tests and service‐side logic accordingly. Key changes include:
- New serialization logic (via header_schema_id_serializer and dual_schema_id_deserializer) that uses a SchemaId object carrying both numeric and GUID values.
- Updates to schema caching and lookup in SchemaRegistryClient to support GUID‐based queries.
- New and updated test cases for schema ID/GUID in the header for protobuf, JSON, and Avro serdes.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/schema_registry/*.py | Test updates to exercise schema ID in header via new serializer configuration |
src/confluent_kafka/schema_registry/serde.py | New SchemaId class to handle both numeric ID and GUID conversions |
src/confluent_kafka/schema_registry/schema_registry_client.py | Changes in schema cache and registered schema functions to support GUID storage and lookup |
src/confluent_kafka/schema_registry/init.py | Addition of header_schema_id_serializer and related serializer/deserializer changes |
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups