Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update checker feature #123

Merged
merged 3 commits into from
May 3, 2022
Merged

Add update checker feature #123

merged 3 commits into from
May 3, 2022

Conversation

rxbn
Copy link
Member

@rxbn rxbn commented May 2, 2022

No description provided.

@rxbn rxbn added the enhancement New feature or request label May 2, 2022
@rxbn rxbn requested a review from gi8lino May 2, 2022 10:15
@rxbn rxbn self-assigned this May 2, 2022
@rxbn rxbn force-pushed the feat/update-chcker branch from d4a08cb to 73a489b Compare May 2, 2022 10:43
@rxbn rxbn changed the title Add update chcker feature Add update checker feature May 2, 2022
Copy link
Member

@gi8lino gi8lino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this feature is useful. There are other mechanismn to check for updates, like renovate...
If there is an update, you have to check the logs and I think nobody checks the log frequently.
Also another dependency (github) was added which must be maintained.
But the code look okay!

@rxbn rxbn merged commit 10cd540 into master May 3, 2022
@rxbn rxbn deleted the feat/update-chcker branch May 3, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants