Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/fsouza/go-dockerclient to v1.10.0 #5007

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 29, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Type Update Change
github.com/fsouza/go-dockerclient require minor v1.9.7 -> v1.10.0

Release Notes

fsouza/go-dockerclient (github.com/fsouza/go-dockerclient)

v1.10.0

Compare Source

v1.9.8

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 29, 2023
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 2 times, most recently from e9765a7 to dfd3590 Compare August 30, 2023 10:12
@renovate renovate bot changed the title Update module github.com/fsouza/go-dockerclient to v1.9.8 fix(deps): update module github.com/fsouza/go-dockerclient to v1.9.8 Aug 31, 2023
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch from dfd3590 to d465f7f Compare August 31, 2023 10:44
@rhatdan rhatdan force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch from d465f7f to 689b913 Compare September 2, 2023 10:58
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 9 times, most recently from 7f27db8 to ccd24e0 Compare September 8, 2023 17:22
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 6 times, most recently from 278fa17 to e3c0066 Compare September 14, 2023 12:28
@nalind
Copy link
Member

nalind commented Sep 14, 2023

This update to go-dockerclient requires Go 1.20, while Fedora 37 only includes Go 1.19.

@rhatdan
Copy link
Member

rhatdan commented Sep 14, 2023

Ok we can bump the version as soon as @cevich migrates us to F38,f39

@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 2 times, most recently from cf4253f to c848a9e Compare September 14, 2023 19:01
@cevich
Copy link
Member

cevich commented Sep 14, 2023

Oof, how the heck will I remember to do this. Also, unless we keep this PR open, renovate will keep pestering about this update 😕 Hmmmm. Is there a go.mod way to use different versions for different toolchains?

The only other idea I have is to add an exception to the renovate config w/ a FIXME comment, then pepper the image build scripts with links pointing at it. That will shut up renovate (including for vulnerability alerts I think) and stands a chance of me remembering to re-enable it later.

Any better ideas?

@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 3 times, most recently from 18b3191 to 29a69bb Compare September 19, 2023 00:22
@renovate renovate bot changed the title fix(deps): update module github.com/fsouza/go-dockerclient to v1.9.8 Update module github.com/fsouza/go-dockerclient to v1.9.8 Sep 20, 2023
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch from 517d1c3 to 4eb88be Compare November 17, 2023 10:42
@openshift-ci openshift-ci bot removed the lgtm label Nov 17, 2023
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch 2 times, most recently from 09e36f5 to 66d304d Compare November 17, 2023 17:37
@cevich
Copy link
Member

cevich commented Nov 17, 2023

OMG, this is crazy, why does it constantly propose newer and newer updates. This will never get in at this rate. Maybe there's a way to stop the update-madness...

@cevich cevich added the stop-updating Force renovate to stop updating a PR it previously opened. label Nov 17, 2023
@renovate renovate bot force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch from 66d304d to 938cf15 Compare November 19, 2023 15:07
cevich added a commit that referenced this pull request Nov 20, 2023
Specifically, the 1.20 version is needed for the updated
go-dockerclient.  Ref:

#5007 (comment)

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023
renovate bot and others added 2 commits November 20, 2023 10:46
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Specifically, the 1.20 version is needed for the updated
go-dockerclient.  Ref:

#5007 (comment)

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the renovate/git.1-hub.cn-fsouza-go-dockerclient-1.x branch from 6670791 to 7add02a Compare November 20, 2023 15:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023
@cevich
Copy link
Member

cevich commented Nov 20, 2023

Force-push: Rebased, ran make vendor-in-container.

@cevich
Copy link
Member

cevich commented Nov 20, 2023

@rhatdan @nalind PTAL. CI is green (finally). Can we please merge this quickly?

I'm afraid Renovate (annoyingly) will decide it needs force-push again 😖

@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2023
@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

/hold cancel

@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

@cevich if you could figure out how to turn this off, so that it matches Podman, that would be great.

@openshift-merge-bot openshift-merge-bot bot merged commit c36ab60 into main Nov 20, 2023
@cevich
Copy link
Member

cevich commented Nov 20, 2023

if you could figure out how to turn this off, so that it matches Podman, that would be great.

I'm assuming "this" means "Renovate's annoying daily force-pushes". It's very perplexing and frustrating for me because podman and buildah already share a common configuration 😕

Looking at the shared/common configuration, it says: Propose golang package version-bumps as soon as Renovate notices. For golang digest-based package updates, restrict update PRs to once per month.

The only "special" thing in podman's setup (and not buildah's) is regarding github.com/containers/* packages. For those, update proposals are restricted to once per day and updates to:

          "^github.com/containers/common",
          "^github.com/containers/image",
          "^github.com/containers/storage",

are grouped together into a single PR.


Re: force-push behavior, I'm similarly perplexed. Supposedly adding a non-renovate-bot commit is suppose to stop that. So is adding the stop-updating label. Neither appears to be working 😞 At this point I think this is a Renovate bug. However a non-trivial reproducer will be needed to report that, and package version changes are out of our control.


The only easy option I see at the moment is to restrict golang packge version bumps based on a fixed schedule. Like once per day or week or month or similar. Could that suffice?

@cevich
Copy link
Member

cevich commented Nov 20, 2023

@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch 18 times, most recently from e0abfff to bfb8c04 yesterday in #5173 apparently it's all golang "tidy" stuff.

Perhaps that's what causes so many "updates".

@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

I think once per/day would be fine.

cevich added a commit to cevich/automation that referenced this pull request Nov 21, 2023
Ref:
containers/buildah#5007 (comment)

Attempt to limit excessive Renovate force-push activity related to
golang update PRs.  This is unlikely a perfect fix, and it may not
address the problem at all.  I believe there's a renovate and/or
configuration bug here, but lack the resources/time to investigate more
deeply - this likely requires a temp. reproduction repo. + mock golang
package.

Signed-off-by: Chris Evich <cevich@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved dependencies Pull requests that update a dependency file lgtm locked - please file new issue/PR stop-updating Force renovate to stop updating a PR it previously opened.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants