-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/fsouza/go-dockerclient to v1.10.0 #5007
fix(deps): update module github.com/fsouza/go-dockerclient to v1.10.0 #5007
Conversation
e9765a7
to
dfd3590
Compare
dfd3590
to
d465f7f
Compare
d465f7f
to
689b913
Compare
7f27db8
to
ccd24e0
Compare
278fa17
to
e3c0066
Compare
This update to go-dockerclient requires Go 1.20, while Fedora 37 only includes Go 1.19. |
Ok we can bump the version as soon as @cevich migrates us to F38,f39 |
cf4253f
to
c848a9e
Compare
Oof, how the heck will I remember to do this. Also, unless we keep this PR open, renovate will keep pestering about this update 😕 Hmmmm. Is there a The only other idea I have is to add an exception to the renovate config w/ a FIXME comment, then pepper the image build scripts with links pointing at it. That will shut up renovate (including for vulnerability alerts I think) and stands a chance of me remembering to re-enable it later. Any better ideas? |
18b3191
to
29a69bb
Compare
517d1c3
to
4eb88be
Compare
09e36f5
to
66d304d
Compare
OMG, this is crazy, why does it constantly propose newer and newer updates. This will never get in at this rate. Maybe there's a way to stop the update-madness... |
66d304d
to
938cf15
Compare
Specifically, the 1.20 version is needed for the updated go-dockerclient. Ref: #5007 (comment) Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Specifically, the 1.20 version is needed for the updated go-dockerclient. Ref: #5007 (comment) Signed-off-by: Chris Evich <cevich@redhat.com>
6670791
to
7add02a
Compare
Force-push: Rebased, ran |
/lgtm |
/hold cancel |
@cevich if you could figure out how to turn this off, so that it matches Podman, that would be great. |
I'm assuming "this" means "Renovate's annoying daily force-pushes". It's very perplexing and frustrating for me because podman and buildah already share a common configuration 😕 Looking at the shared/common configuration, it says: Propose golang package version-bumps as soon as Renovate notices. For golang digest-based package updates, restrict update PRs to once per month. The only "special" thing in podman's setup (and not buildah's) is regarding
are grouped together into a single PR. Re: force-push behavior, I'm similarly perplexed. Supposedly adding a non-renovate-bot commit is suppose to stop that. So is adding the The only easy option I see at the moment is to restrict golang packge version bumps based on a fixed schedule. Like once per day or week or month or similar. Could that suffice? |
Perhaps that's what causes so many "updates". |
I think once per/day would be fine. |
Ref: containers/buildah#5007 (comment) Attempt to limit excessive Renovate force-push activity related to golang update PRs. This is unlikely a perfect fix, and it may not address the problem at all. I believe there's a renovate and/or configuration bug here, but lack the resources/time to investigate more deeply - this likely requires a temp. reproduction repo. + mock golang package. Signed-off-by: Chris Evich <cevich@redhat.com>
This PR contains the following updates:
v1.9.7
->v1.10.0
Release Notes
fsouza/go-dockerclient (github.com/fsouza/go-dockerclient)
v1.10.0
Compare Source
v1.9.8
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.