Ensure the mount type is always BindMount by default #5067
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminSchubert
changed the title
Previously, when mounting multiple mounts, if any mount had a `type` specified, it would override the default type for subsequent mounts. This meant, for example, that having a RUN step like: ``` RUN --mount=type=cache,target=/cache --mount=source=.,target=/src ``` would incorrectly mount the second source as a cache, instead of a bind-mount. This fix ensures the default is reset between each iteration of the loop, ensuring we get the right mount type. Signed-off-by: Benjamin Schubert <contact@benschubert.me>
BenjaminSchubert
force-pushed
the
bschubert/fix-cache-type-default
branch
from
7e09fd2 to
249e30c
Compare
|
Nice catch, thanks! LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenjaminSchubert, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, when mounting multiple mounts, if any mount had a
typespecified, it would override the default type for subsequent mounts.This meant, for example, that having a RUN step like:
would incorrectly mount the second source as a cache, instead of a bind-mount.
This fix ensures the default is reset between each iteration of the loop, ensuring we get the right mount type.
How to verify it
Try to build the provided Dockerfile without the patch applied. This will fail, complaining that
/test/input_fileis a directory.Now apply the patch and see that it correctly outputs
hello.Any variation of mounts before one not specifying
typewould also work.Which issue(s) this PR fixes:
None, I can create one if required.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Technically, this is a breaking change for users using buildah, as their mounts might change types. I am unsure what to write here, can someone please provide guidance, or update the release notes?