Make TEE types case-insensitive #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
nalind
force-pushed
the
case-insensitive-tee-types
branch
from
0324ab8 to
775dc94
Compare
Make sure that we accept both upper- and lower-cased versions of the names of TEE types as arguments for `buildah build`'s --cw flag and for `buildah mkcw`'s --type flag. We previously only understood lower-case versions, but the docs always used upper case. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
case-insensitive-tee-types
branch
from
775dc94 to
0a85c06
Compare
Add some godoc for pkg/parse.GetTempDir() Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make sure that we accept both upper- and lower-cased versions of the names of TEE types as arguments for
buildah build's --cw flag and forbuildah mkcw's --type flag. We previously only understood lower-case versions, but the docs always used upper case.While we're in here, add some missing godoc for an unrelated function.
How to verify it
Extended integration tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?