Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TEE types case-insensitive #5159

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Nov 13, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Make sure that we accept both upper- and lower-cased versions of the names of TEE types as arguments for buildah build's --cw flag and for buildah mkcw's --type flag. We previously only understood lower-case versions, but the docs always used upper case.

While we're in here, add some missing godoc for an unrelated function.

How to verify it

Extended integration tests!

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TEE types used with `buildah build --cw` and `buildah mkcw` are no longer required to be specified in lower-case.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. approved labels Nov 13, 2023
@nalind nalind force-pushed the case-insensitive-tee-types branch from 0324ab8 to 775dc94 Compare November 14, 2023 12:24
Make sure that we accept both upper- and lower-cased versions of the
names of TEE types as arguments for `buildah build`'s --cw flag and for
`buildah mkcw`'s --type flag.  We previously only understood lower-case
versions, but the docs always used upper case.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind force-pushed the case-insensitive-tee-types branch from 775dc94 to 0a85c06 Compare November 14, 2023 20:04
Add some godoc for pkg/parse.GetTempDir()

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e2c8519 into containers:main Nov 16, 2023
@nalind nalind deleted the case-insensitive-tee-types branch November 16, 2023 14:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/bug Categorizes issue or PR as related to a bug. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants