build: downgrade to go 1.20 #5166
Conversation
giuseppe
force-pushed
the
use-go-1.20
branch
from
ee0ad97 to
74ba96d
Compare
|
/lgtm |
There was a problem hiding this comment.
https://github.com/containers/buildah/pull/5139/files also changed the vendor-in-container rule.
I’m not sure this is completely necessary but the consistency is attractive.
giuseppe
force-pushed
the
use-go-1.20
branch
from
74ba96d to
7286681
Compare
good point, fixed now |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Restarted flaking test, @giuseppe I think PR needs rebase. ( otherwise merge bot will block ) |
go 1.21 breaks the Podman CI since it is not available on Fedora 38. [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
rebased |
giuseppe
force-pushed
the
use-go-1.20
branch
from
7286681 to
fe9bdce
Compare
|
/lgtm |
|
/unhold |
go 1.21 breaks the Podman CI since it is not available on Fedora 38.
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?