-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move footnotes on divisive language to exactly where divisive language is used #5221
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krumelmonster The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@krumelmonster nice change! Unfortunately our CI won't take a PR unless it's signed. Can you do a LGTM other than the CI unhappiness. |
@TomSweeneyRedHat see containers/podman#20983 I'm working on that on the podman side, and I can take this one on as well with @krumelmonster's permission. |
Thank you for picking it up @edsantiago! I really like podman and buildah for being tools that can be understood based on documentation and manpage @TomSweeneyRedHat I knew I could sign it but I was insecure whether a signature with a non-legal name would be frowned upon. I take your comment as an invitation to make pull requests in the future under the name krumelmonster with which I'm active in OSS; it is very appreciated. |
Works for me @krumelmonster , thanks! |
Followthrough on containers#5221, with thanks to @krumelmonster: move footnotes on divisive language to exactly where divisive language is used Signed-off-by: Ed Santiago <santiago@redhat.com>
Followthrough on containers#5221, with thanks to @krumelmonster: move footnotes on divisive language to exactly where divisive language is used Signed-off-by: Ed Santiago <santiago@redhat.com>
Followthrough on containers#5221, with thanks to @krumelmonster: move footnotes on divisive language to exactly where divisive language is used Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
My commit is not signed or using a realname but I don't believe that the changes I've made can be subject to copyright.
What type of PR is this?
What this PR does / why we need it:
I got a bit confused when reading the manpage as the footnote on problematic and divisive language appeared after a sentence that doesn't use problematic and divisive language and I think moving the footnote to just after the wording deemed problematic makes the manpage more readable
How to verify it
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?