Replace strings.SplitN with strings.Cut #5239
Conversation
openshift-ci
bot
added
the
kind/cleanup
| @@ -845,23 +838,18 @@ func (b *Executor) Build(ctx context.Context, stages imagebuilder.Stages) (image | |||
| fields := strings.Split(mountFlags, ",") | |||
| for _, field := range fields { | |||
| if strings.HasPrefix(field, "from=") { | |||
| fromField := strings.SplitN(field, "=", 2) | |||
| if len(fromField) > 1 { | |||
There was a problem hiding this comment.
I removed this condition for 2 reasons:
- it can never happen, since we know
=appears infield - the error message in the dead else path had an out of bounds access with
formField[1]
| @@ -124,23 +124,20 @@ func GetBindMount(ctx *types.SystemContext, args []string, contextDir string, st | |||
| return newMount, "", fmt.Errorf("cannot pass 'relabel' option more than once: %w", errBadOptionArg) | |||
| } | |||
| setRelabel = true | |||
| if len(kv) != 2 { | |||
There was a problem hiding this comment.
I removed this check because the exact same error will be raised by the default case
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serprex, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Sure, I'll take a look. I was looking over code while looking into podman's support for |
serprex
changed the title
Introduced in go 1.18: golang/go#46336 [NO NEW TESTS NEEDED] Signed-off-by: Philip Dubé <philip@peerdb.io>
|
rebased to clean up commit messages since commit subject was too long |
|
/lgtm |
|
LGTM |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
strings.Cutis a cleaner & more performant api relative tostrings.SplitN(_, _, 2)added in go 1.18How to verify it
No change in behavior
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Introduced in go 1.18: golang/go#46336
Does this PR introduce a user-facing change?