[release-1.38] tag v1.38.1 #5918
Conversation
The changelog.txt and CHANGELOG.md files each had "vv1.37" instead of "v1.37". This corrects that. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
nalind
added
the
No New Tests
|
/retitle [release-1.38] tag v1.38.1 |
Tag a new release to incorporate the recent security advisory, and make a minor update to the CI configuration and Makefile. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
| @@ -6,7 +6,7 @@ env: | |||
| #### Global variables used for all tasks | |||
| #### | |||
| # Name of the ultimate destination branch for this CI run, PR or post-merge. | |||
| DEST_BRANCH: "main" | |||
| DEST_BRANCH: "release-1.38" | |||
There was a problem hiding this comment.
Oops, missed this, thanks for the correction @nalind
| @@ -2,6 +2,19 @@ | |||
|
|
|||
| # Changelog | |||
|
|
|||
| ## v1.38.1 (2025-01-20) | |||
|
|
|||
| Fix TOCTOU error when bind and cache mounts use "src" values | |||
There was a problem hiding this comment.
Any possibility to adding a [release-1.38] tag to these commits? It looks like the push just grabbed them from main.
There was a problem hiding this comment.
They were cherry-picked for their respective branches. For release-1.38 I don't recall needing to make any changes. I'm not sure I understand the benefit of going back and retitling the commits, though...?
There was a problem hiding this comment.
Oh, the actual commits were merged, so changing their commit logs would mean rewriting the history on the branch, which means we can't do that anyway.
There was a problem hiding this comment.
I just find it easier when sorting through history and the change logs to see the leading tags. YMMV, I'm OK with not adding them
There was a problem hiding this comment.
Right now, they match the commits. It's fine.
|
One tagging quesiton, otherwise LGTM. |
|
LGTM |
Changing the summaries in the commit log would require rewriting the commit history, and we're not doing that here. The changelog files reflect the commit log. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-merge-bot
bot
merged commit 0e6c0bc
into
containers:release-1.38
|
LGTM |
What type of PR is this?
/kind other
What this PR does / why we need it:
Tag a v1.38.1 release to incorporate the recent security update.
How to verify it
The test suite should be enough.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?