Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Inline Tip in VSCode #4325

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

Link4565
Copy link

Description

Remove background and outline of tip from SVG. This is required since the SVG content of a decoration cannot be taller than the line text height without causing the entire line to be pushed down. Fixes #4324

Replace the box outline and background with CSS.

Fix spacing of text inside box. Add '+' symbols to shortcuts to make them clearer.

Checklist

  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

Before:
Screenshot 2025-02-24 135511
Screenshot 2025-02-24 135526

After:
Screenshot 2025-02-24 135626
Screenshot 2025-02-24 135640

Testing instructions

  1. Install extension in Visual Studio Code
  2. Open a non-empty file
  3. Select some text
  4. Verify that the updated inline tip opens, and that the other text content on the line does not move down.

Remove background and outline of tip from SVG. This is required since the SVG content of a decoration cannot be taller than the line text height without causing the entire line to be pushed down.

Replace the box outline and background with CSS.

Fix spacing of text inside box. Add '+' symbols to shortcuts to make them clearer.
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 38fd654
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67bc7b164a939d000807e980
😎 Deploy Preview https://deploy-preview-4325--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sestinj
Copy link
Contributor

sestinj commented Feb 27, 2025

this looks great!

@sestinj sestinj merged commit de9558f into continuedev:main Feb 27, 2025
32 checks passed
@Link4565 Link4565 deleted the improve-inline-tip branch February 27, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected text in vscode pops up "chat" and "edit" selections resulting in lowering the line of selected text
2 participants