Skip to content

[Question] How to localize #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NikoGrano opened this issue Feb 28, 2020 · 2 comments
Closed

[Question] How to localize #67

NikoGrano opened this issue Feb 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@NikoGrano
Copy link

How can I localize https://github.com/coreui/coreui-vue/blob/master/src/components/table/CDataTable.vue#L147?

This is just one example.

If this is something what havent been discussed or think about, I could create there new prop, called localization. That would be object with example data of

localization: {
    error-no-results: string = 'No filtering results',
    error-no-items: string = 'No items',
    
}

This is just pure thinking on the spot, but hardcoding these in english into the component, is not really the way to do it.

@woothu
Copy link

woothu commented Feb 28, 2020

You are correct, the solution for this is using 'no-items-view' slot.

Anyway, we will consider adding additional prop.

@woothu woothu added the enhancement New feature or request label Mar 6, 2020
@woothu
Copy link

woothu commented Mar 10, 2020

noItemsView prop was added in f130496, and will be available with the next release

@woothu woothu closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants