Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF:reproject: Make NaN default float nodata & update integer defaults #797

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Jul 18, 2024

OverflowError: Unable to convert nodata value (3.402823466e+38) to new dtype (float32).

Related #782

Integer defaults changed to match: https://github.com/rasterio/rasterio/blob/9e643c3f563a679aa5400d9b1a263df97b34f9e0/rasterio/dtypes.py#L99-L112

@snowman2 snowman2 force-pushed the nodata branch 3 times, most recently from 92433cd to 687b4d0 Compare July 18, 2024 20:26
@alfredoahds
Copy link

Looks good to me.

@snowman2 snowman2 merged commit 0ece381 into corteva:master Jul 18, 2024
13 of 19 checks passed
@snowman2 snowman2 deleted the nodata branch July 18, 2024 20:50
@snowman2
Copy link
Member Author

Thanks @alfredoahds 👍

@snowman2 snowman2 added this to the 0.16.1 milestone Jul 18, 2024
@snowman2 snowman2 added bug Something isn't working enhancement New feature or request labels Jul 18, 2024
@snowman2 snowman2 requested a review from alfredoahds July 18, 2024 21:02
Copy link

@alfredoahds alfredoahds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants