Skip to content

Incorrect branch coverage async pattern for targetframework net472 #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2021
Merged

Incorrect branch coverage async pattern for targetframework net472 #1169

merged 5 commits into from
May 30, 2021

Conversation

daveMueller
Copy link
Collaborator

closes #1167

MarcoRossignoli
MarcoRossignoli reviewed May 28, 2021
View reviewed changes
test/coverlet.tests.projectsample.netframework/coverlet.tests.projectsample.netframework.csproj
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net472</TargetFramework>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

    <IsPackable>false</IsPackable>
    <IsTestProject>false</IsTestProject>

like https://github.com/coverlet-coverage/coverlet/blob/master/test/coverlet.tests.projectsample.empty/coverlet.tests.projectsample.empty.csproj

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

MarcoRossignoli
MarcoRossignoli reviewed May 28, 2021
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, LGTM

@MarcoRossignoli MarcoRossignoli added the tenet-coverage Issue related to possible incorrect coverage label May 28, 2021
@sergiusignacius
Copy link

Woot, thanks folks! 👍

@MarcoRossignoli
Copy link
Collaborator

@daveMueller small conflict to handle and we can merge a HUGE thanks!

@daveMueller
Merge branch 'upstream/master' into 1167_AsyncBranchNetFramework
fae5730 
# Conflicts:
#	Documentation/Changelog.md
#	coverlet.sln
@MarcoRossignoli MarcoRossignoli merged commit 4902c24 into coverlet-coverage:master May 30, 2021
@daveMueller daveMueller deleted the 1167_AsyncBranchNetFramework branch September 12, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

Assignees
No one assigned
Labels
tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect branch coverage with .NET 472
3 participants
@daveMueller @sergiusignacius @MarcoRossignoli