ExcludeByFile add traversal support when full path specified. #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
System.ArgumentException: ".." can be only added at the beginning of the pattern.
when specifying full path with path traversal:
<ExcludeByFile>$(MSBuildThisFileDirectory)../**/*.Designer.cs</ExcludeByFile>
The main problem might be that we can't specify our own root path, it's ether
Directory.GetCurrentDirectory()
orPath.GetRootPath(pattern)
.