Remove reliance on s_isTracking to detect recursion #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet/coreclr#21994
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 88.85% 89.06% +0.21%
==========================================
Files 16 16
Lines 1875 1912 +37
==========================================
+ Hits 1666 1703 +37
Misses 209 209
Continue to review full report at Codecov.
|
petli
reviewed
Jan 15, 2019
|
@sharwell Is this PR ready to be merged? |
|
@codemzs No, I'm working with @ViktorHofer to figure this out still |
sharwell
changed the title
sharwell
force-pushed
the
default-init
branch
2 times, most recently
from
367315f to
db5dbc5
Compare
sharwell
changed the title
|
OK this should be ready now 😄 |
sharwell
force-pushed
the
default-init
branch
from
db5dbc5 to
be7a5d6
Compare
sharwell
commented
Jan 15, 2019
| @@ -76,6 +77,7 @@ private void InstrumentModule() | |||
|
|
|||
| using (var module = ModuleDefinition.ReadModule(stream, parameters)) | |||
| { | |||
| var containsAppContext = module.GetType(nameof(System), nameof(AppContext)) != null; | |||
There was a problem hiding this comment.
📝 This could be modified to also check the name of the containing assembly, but it didn't seem necessary.
|
I validated the fix together with @sharwell offline and we finally got our code coverage for System.Private.CoreLib back hooray. |
ViktorHofer
approved these changes
Jan 15, 2019
sharwell
force-pushed
the
default-init
branch
from
be7a5d6 to
96b1594
Compare
|
cc @tonerdo |
tonerdo
approved these changes
Jan 16, 2019
|
I see you all have been busy 😄. Thanks for all the help guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/coreclr#21994
The stack overflow was caused when a call to
RecordHitoccurred prior to the initialization ofHitsArray, which in turn called an instrumented constructor forNullReferenceException.