Fix strong name validation failures #303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
======================================
Coverage 87.5% 87.5%
======================================
Files 16 16
Lines 2041 2041
======================================
Hits 1786 1786
Misses 255 255 |
|
@tonerdo This is a different kind of failure. I verified that .NET Framework will not instrument assemblies without this change in place. Verified using AppVeyor builds 2.5.2+bf6db4dbf5 (without this change integrated) and 2.5.4+e7f54017e0 (with this change integrated). Note that this change alone with not make .NET Framework scenarios work. #299 will be needed as well at a minimum. I recommend including #301 as well to make the whole testing and deployment process much easier (you get one-click automated releases). |
|
Why do we need the new coverlet templates assembly at all? |
|
@ViktorHofer There will be two copies of coverlet.templates in the NuGet package one way or the other. There doesn't seem to be any drawback to multi-targeting this assembly according to the runtime support. |
For now, ConsoleTables is referenced as a source copy. It can be replaced by a PackageReference as soon as the original adopts a strong name. See khalidabuhakmeh/ConsoleTables#30
|
@tonerdo this is a simple change which resolves the long standing strong name validation errors that we were hitting in coverlet plus it removes a dependency which always nice. Can we get this merged? |
This was an undesirable side effect of a bug outside control of this repository. I'm going to file a follow-up issue to switch back to using the dependency once the source bug has been resolved. |
This is a prerequisite for coverlet.msbuild.tasks working on .NET Framework (#299).