-
Notifications
You must be signed in to change notification settings - Fork 17
fix: group overloads per access level #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: group overloads per access level #895
Conversation
An automated preview of the documentation is available at https://895.mrdocs.prtest2.cppalliance.org/index.html |
68943f1
to
c6e6a6f
Compare
An automated preview of the documentation is available at https://895.mrdocs.prtest2.cppalliance.org/index.html |
c6e6a6f
to
38c51f3
Compare
An automated preview of the documentation is available at https://895.mrdocs.prtest2.cppalliance.org/index.html |
Oh... That's nice. Is it good to go? |
Yes, this is good to go. |
I just noticed the test in test-files/golden-tests/config/overloads/visibility.cpp won't form any overload sets. It's good to check if it's not forming when it shouldn't form but also forming these separate sets when they are expected by the PR. |
38c51f3
to
744c9bc
Compare
An automated preview of the documentation is available at https://895.mrdocs.prtest2.cppalliance.org/index.html |
OK. Merging it after #896. |
744c9bc
to
19b7b0c
Compare
An automated preview of the documentation is available at https://895.mrdocs.prtest2.cppalliance.org/index.html |
The
OverloadFinalizer
groups functions for one access level and "static" level. However, the ID assigned to the overloads only took the parent and function name into account. This meant that functions of the same name in a different access level would map to the same ID and be discarded if that ID already existed (emplace
behavior).The ID for overloads now takes the access level and "static" level into account.