Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with clang-cl, there are warnings not present with MSVC
/MP
isn't a thing in clang-cl./W4
enables-Wunused-parameter
in clang-cl (or this might be enabled by default) - either way, it's not enabled in MSVC and generates some warnings here.getRawUnqualified
returned astd::string_view
to a temporarystd::string
and clang warned about it.-Wself-move
was ignored when__GNUC__
was defined. This isn't defined with clang-cl, so ignore it in the clang block.