Skip to content

fix(clang-cl): reduce warnings #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 23, 2025

When compiling with clang-cl, there are warnings not present with MSVC

  • /MP isn't a thing in clang-cl.
  • /W4 enables -Wunused-parameter in clang-cl (or this might be enabled by default) - either way, it's not enabled in MSVC and generates some warnings here.
  • getRawUnqualified returned a std::string_view to a temporary std::string and clang warned about it.
  • -Wself-move was ignored when __GNUC__ was defined. This isn't defined with clang-cl, so ignore it in the clang block.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://900.mrdocs.prtest2.cppalliance.org/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants